Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manage landscape preset configuration #10297

Merged
merged 17 commits into from
Jul 18, 2024
Merged

manage landscape preset configuration #10297

merged 17 commits into from
Jul 18, 2024

Conversation

renanfranca
Copy link
Contributor

Fix #10239

@renanfranca renanfranca self-assigned this Jul 16, 2024
@renanfranca renanfranca marked this pull request as ready for review July 16, 2024 16:22
@renanfranca renanfranca requested a review from murdos July 16, 2024 16:22
murdos
murdos previously approved these changes Jul 18, 2024
View reviewed changes
renanfranca added 16 commits July 18, 2024 08:25
@renanfranca
feat: read presets from json file
06b8116
@renanfranca
feat: preset name can not be null or empty
23b10e4
@renanfranca
feat: preset modules can not be null or empty
036b287
@renanfranca
refactor(FileSystemPresetRepository): use Path as parameter type
ef7012d
@renanfranca
refactor(FileSystemPresetRepository): inline and simplify json conver…
b2ae15e 
…sion
@renanfranca
feat: get empty preset from unknown file
da9f23c
@renanfranca
refactor: define preset json file name as a constant
bcf5d03
@renanfranca
feat: must not be null the path to folder passed as parameter which s…
023cabf 
…hould contains the preset json file
@renanfranca
feat: set the location of the preset.json file at the root of the res…
8fa5a1e 
…ource's folder
@renanfranca
refactor(FileSystemPresetRepositoryTest): improve usage of mocks
082cdb6
@renanfranca
refactor(FileSystemPresetRepositoryTest): improve readability of shou…
a059ddb 
…ldGetExistingPreset method
@renanfranca
test(FileSystemPresetRepositoryTest): ensure deserialization errors a…
3e78750 
…re handled
@renanfranca
refactor: improve readability of conversion from PersistedPreset to P…
d79a6bf 
…reset
@renanfranca
fix(FileSystemPresetRepositoryTest): properly handle deserialization …
b1ea9a1 
…errors by avoiding exceptions from ProjectFiles.readBytes method
@renanfranca
refactor(preset): move the preset logic to ProjectsRepository interface
d49eaa9
@renanfranca
fix(FileSystemProjectsRepository): change constant visibility to private
7303ca0
@renanfranca renanfranca force-pushed the 10239-manage-landscape-preset-configuration branch from 32e24b3 to 9303ced Compare July 18, 2024 11:28
@renanfranca renanfranca enabled auto-merge July 18, 2024 11:33
@renanfranca renanfranca merged commit 467be59 into jhipster:main Jul 18, 2024
34 checks passed
@renanfranca renanfranca deleted the 10239-manage-landscape-preset-configuration branch July 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murdos murdos murdos left review comments

Assignees

@renanfranca renanfranca

Labels
area: feature request 💡 generator: internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage landscape preset configuration
2 participants
@renanfranca @murdos