Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(VersionsCatalog): move libraryEntriesMatchingDependency meth… #10238

Merged
merged 1 commit into from
Jul 9, 2024
Merged

refactor(VersionsCatalog): move libraryEntriesMatchingDependency meth… #10238

merged 1 commit into from
Jul 9, 2024

Conversation

renanfranca
Copy link
Contributor

…od next to the method that uses it first

@renanfranca renanfranca self-assigned this Jul 9, 2024
@renanfranca renanfranca requested a review from murdos July 9, 2024 12:48
murdos
murdos approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@murdos murdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Idea 😀

@murdos murdos merged commit ee530b4 into jhipster:main Jul 9, 2024
35 checks passed
@renanfranca renanfranca deleted the refactor-versionscatalog-by-moving-private-method branch July 9, 2024 20:03
@renanfranca
Copy link
Contributor Author

Good Idea 😀

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murdos murdos murdos approved these changes

Assignees

@renanfranca renanfranca

Labels
area: refactoring generator: internal theme: gradle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renanfranca @murdos