safely remove libs version reference #10191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f784a86 to
f868452
Compare
…ion and entry in versions section when remove dependency
…ith version without exclusion
…rary entry removal
…ry when removed dependency is in build gradle profile file
…s section but kept in versions section if still used by another dependency
… by another library
… version before trying to remove the version
…section but retain in versions section if used by dependency in build gradle profile file
…ion and entry in versions section when remove dependency management
…ry when removed dependency management is in build gradle profile file
…section but retain in versions section if used by another dependency management
…section but retain in versions section if used by dependency management in build gradle profile file
…icated method for improved readability
f868452 to
fdb31db
Compare
|
@murdos : I generated a sampleapp with gradle using this pull request implementation and it removed the unused versions ( |
…ethod that uses it first
Thanks 😊 |
@renanfranca : Sorry, I've no idea 🤷♂️ |
|
I will let it go for now and keep watching it. I tried to rerun all jobs and got a Sonar not initialized error, but when I ran it on localhost, it worked fine. |
|
@pascalgrimaud: Bounty Claimed https://opencollective.com/generator-jhipster/expenses/210043. Thanks 😀✌ |
|
@renanfranca : approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10060 (see the TO-DO at issue description)