Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar: Rename this generic name to match the regular expression #10167

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Sonar: Rename this generic name to match the regular expression #10167

merged 1 commit into from
Jul 1, 2024

Conversation

qmonmert
Copy link
Contributor

Fix:

@qmonmert qmonmert marked this pull request as ready for review June 28, 2024 12:22
@qmonmert qmonmert requested review from murdos and pascalgrimaud June 28, 2024 12:23
murdos
murdos reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@murdos murdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rather disable this Sonar rule.
Current code is more expressive and maintainable than the one enforced by Sonar.

@qmonmert
Copy link
Contributor Author

@murdos ok but if we disable a lot of rules, why have Sonar?

@murdos
Copy link
Contributor

murdos commented Jul 1, 2024

@murdos ok but if we disable a lot of rules, why have Sonar?

@qmonmert : A lot of rules are interesting, and some are not. We can't directly configure the applied rules, they're defined in the quality profile defined on the SonarQube server: https://sonarcloud.io/organizations/jhipster/quality_profiles/show?name=Sonar+way&language=java
It's similar to eslint, that provides a lot of rules. Some are part of the recommended config, and some are just provided but not enabled, and each project/team decides what rules are applied.

@qmonmert qmonmert requested a review from murdos July 1, 2024 20:36
@murdos murdos merged commit 7ff719b into jhipster:main Jul 1, 2024
34 checks passed
@pascalgrimaud
Copy link
Member

shouldn't it be applied to generated config too ?

@qmonmert qmonmert mentioned this pull request Jul 5, 2024
Merged
@qmonmert
Copy link
Contributor Author

qmonmert commented Jul 5, 2024

@pascalgrimaud done here #10212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murdos murdos murdos approved these changes

@pascalgrimaud pascalgrimaud Awaiting requested review from pascalgrimaud

Assignees
No one assigned
Labels
area: enhancement 🔧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qmonmert @murdos @pascalgrimaud