Spring Boot MVC: add Spring Boot Actuator

[pascalgrimaud]

New API with this

[swarajsaaj]

Should it be in "mvc" context instead? Do you feel any use of actuator without a web dependency?

[pascalgrimaud]

Indeed @swarajsaaj you're right, about putting this in MVC

But I don't think actuator should be added by default, so it should be optional, do you agree?

[swarajsaaj]

@pascalgrimaud Yes I agree with a separate API for adding actuator in MVC resource with:-

• Basic endpoints in application properties
• Core health probes
• Keep it under "/management" to match generator-jhipster path
• And core metrics

[pascalgrimaud]

sound perfect. Can I assign to you this ticket ?

[swarajsaaj]

Yes please :)

[swarajsaaj]

There is a conflict with springfox+actuator and spring.mvc.pathmatch.matching-strategy property already added at

jhipster-lite/src/main/java/tech/jhipster/lite/generator/server/springboot/mvc/web/domain/SpringBootMvcDomainService.java

Line 118 in 8d4c8bc

springBootPropertiesService.addProperties(project, "spring.mvc.pathmatch.matching-strategy", "ant_path_matcher");

.

Spring actuator's path matching strategy cannot be configured to AntPathMatcher by properties.
Ref:- https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.6-Release-Notes#pathpattern-based-path-matching-strategy-for-spring-mvc

Are we already planning to replace springfox with springdoc in #219 ? Shall we remove this property in this ticket if we are not going to depend on springfox?

[pascalgrimaud]

Oh I see: it's because I added springfox by default when adding Tomcat MVC or Undertow MVC.
I shouldn't do that:

• so springfox should be removed from MVC
• adding springdoc could be done separately, or maybe should be by default with MVC, I don't' know

[pascalgrimaud]

We could remove first springfox in a 1st PR, then you can continue the work for this ticket separately. What do you think?

[swarajsaaj]

Sure, Looks good 👍

[pascalgrimaud]

@swarajsaaj : I'm doing the PR for removing springfox. I'll submit it in few minutes