-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move husky and lintstaged setup from 'prettier' module to 'init' #10701
Comments
So the init module will have an empty .husky folder and other modules will feed this with pre-commit, pre-push etc files ? |
@fabienpuissant : the init module would have configured husky to run lint-staged, but lint-staged configuration would have no configured rules, until other modules like prettier add rules: .lintstagedrc.js:
|
It seems relevant. I agree with your suggestion @murdos |
@murdos Can I take the point ? |
@fabienpuissant : Sure! Go ahead! :) |
Adding a small bounty since it's more work than expected, and we need to be careful not to break the generation. |
@pascalgrimaud: Bounty Claimed https://opencollective.com/generator-jhipster/expenses/218916. Thanks 😃 |
@fabienpuissant : you need to change your invoice as it must be in dollars, not in euro. Can you? |
Yeah sorry french habits 😆 |
@fabienpuissant : you need to update the new value too, as it was converted |
it's approved, thanks for your patience and thanks for your hard work @fabienpuissant ! |
Git hooks and actions on commit are not specific to prettier.
It would be nice if this was directly available on any initiated project.
An example of non-prettier usage: when you use the protobuf-backwards-compatibility-check module, it would be nice to check and update automatically the lock file when you change protobuf files.
The text was updated successfully, but these errors were encountered: