Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move husky and lintstaged setup from 'prettier' module to 'init' #10701

Closed
murdos opened this issue Aug 29, 2024 · 11 comments · Fixed by #10713
Closed

Move husky and lintstaged setup from 'prettier' module to 'init' #10701

murdos opened this issue Aug 29, 2024 · 11 comments · Fixed by #10713
Assignees
Labels
area: feature request 💡 area: good first issue $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: init $100 https://www.jhipster.tech/bug-bounties/

Comments

@murdos
Copy link
Contributor

murdos commented Aug 29, 2024

Git hooks and actions on commit are not specific to prettier.
It would be nice if this was directly available on any initiated project.

An example of non-prettier usage: when you use the protobuf-backwards-compatibility-check module, it would be nice to check and update automatically the lock file when you change protobuf files.

@fabienpuissant
Copy link
Collaborator

So the init module will have an empty .husky folder and other modules will feed this with pre-commit, pre-push etc files ?

@murdos
Copy link
Contributor Author

murdos commented Aug 29, 2024

@fabienpuissant : the init module would have configured husky to run lint-staged, but lint-staged configuration would have no configured rules, until other modules like prettier add rules:

.lintstagedrc.js:

module.exports = {
};

@pascalgrimaud
Copy link
Member

It seems relevant. I agree with your suggestion @murdos

@fabienpuissant
Copy link
Collaborator

@murdos Can I take the point ?

@murdos
Copy link
Contributor Author

murdos commented Aug 30, 2024

@murdos Can I take the point ?

@fabienpuissant : Sure! Go ahead! :)

fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Aug 31, 2024
fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Aug 31, 2024
fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Sep 2, 2024
fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Sep 2, 2024
fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Sep 2, 2024
fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Sep 2, 2024
fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Sep 3, 2024
fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Sep 3, 2024
fabienpuissant added a commit to fabienpuissant/jhipster-lite that referenced this issue Sep 4, 2024
@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $100 https://www.jhipster.tech/bug-bounties/ labels Sep 5, 2024
@pascalgrimaud
Copy link
Member

Adding a small bounty since it's more work than expected, and we need to be careful not to break the generation.

@fabienpuissant
Copy link
Collaborator

@pascalgrimaud: Bounty Claimed https://opencollective.com/generator-jhipster/expenses/218916. Thanks 😃

@pascalgrimaud
Copy link
Member

@fabienpuissant : you need to change your invoice as it must be in dollars, not in euro. Can you?

@fabienpuissant
Copy link
Collaborator

@fabienpuissant : you need to change your invoice as it must be in dollars, not in euro. Can you?

Yeah sorry french habits 😆

@pascalgrimaud
Copy link
Member

@fabienpuissant : you need to update the new value too, as it was converted

image

@pascalgrimaud
Copy link
Member

it's approved, thanks for your patience and thanks for your hard work @fabienpuissant !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: feature request 💡 area: good first issue $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: init $100 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants