move creation of .npmrc file to the init module (#10889)

move creation of .npmrc file to the init module

Fix #10860

src/main/java/tech/jhipster/lite/generator/client/angular/core/domain/AngularModuleFactory.java

@@ -14,8 +14,6 @@ public class AngularModuleFactory {
 
   private static final JHipsterSource SOURCE = from("client/angular/core");
 
-  private static final JHipsterSource SOURCE_COMMON = from("client/common");
-
   private static final String ENGINES_NEEDLE = "  \"engines\":";
   private static final PackageName ANGULAR_CORE_PACKAGE = packageName("@angular/core");
 
@@ -76,9 +74,6 @@ public JHipsterModule buildModule(JHipsterModuleProperties properties) {
         .add(SOURCE.template("angular.json"), to("angular.json"))
         .add(SOURCE.file("tsconfig.json"), to("tsconfig.json"))
         .add(SOURCE.file("tsconfig.app.json"), to("tsconfig.app.json"))
-        .batch(SOURCE_COMMON, to("."))
-          .addFile(".npmrc")
-          .and()
         .batch(SOURCE, to("."))
           .addTemplate("eslint.config.mjs")
           .addTemplate("proxy.conf.json")

src/main/java/tech/jhipster/lite/generator/client/react/core/domain/ReactCoreModulesFactory.java

@@ -13,7 +13,6 @@
 public class ReactCoreModulesFactory {
 
   private static final JHipsterSource SOURCE = from("client/react/core");
-  private static final JHipsterSource SOURCE_COMMON = from("client/common");
 
   private static final JHipsterSource WEBAPP_SOURCE = SOURCE.append("src/main/webapp");
   private static final JHipsterDestination WEBAPP_DESTINATION = to("src/main/webapp");
@@ -79,9 +78,6 @@ public JHipsterModule buildModule(JHipsterModuleProperties properties) {
           .addTemplate("vitest.config.ts")
           .addTemplate("eslint.config.js")
           .and()
-        .batch(SOURCE_COMMON, to("."))
-          .addFile(".npmrc")
-          .and()
         .batch(APP_SOURCE, APP_DESTINATION)
           .addTemplate("index.css")
           .addTemplate("index.tsx")

src/main/java/tech/jhipster/lite/generator/init/domain/InitModuleFactory.java

@@ -14,6 +14,7 @@ public class InitModuleFactory {
 
   private static final JHipsterSource SOURCE = from("init");
   private static final JHipsterDestination DESTINATION = to(".");
+  private static final JHipsterSource SOURCE_COMMON = from("client/common");
 
   private final NpmVersions npmVersions;
 
@@ -38,6 +39,9 @@ public JHipsterModule buildModule(JHipsterModuleProperties properties) {
           .addTemplate(".editorconfig")
           .addFile(".lintstagedrc.cjs")
           .and()
+        .batch(SOURCE_COMMON, DESTINATION)
+          .addFile(".npmrc")
+          .and()
         .addExecutable(SOURCE.append(".husky").file("pre-commit"), DESTINATION.append(".husky/pre-commit"))
         .add(SOURCE.file("gitignore"), to(".gitignore"))
         .add(SOURCE.file("gitattributes"), to(".gitattributes"))

src/main/java/tech/jhipster/lite/generator/typescript/core/domain/TypescriptModuleFactory.java

@@ -12,7 +12,6 @@
 public class TypescriptModuleFactory {
 
   private static final JHipsterSource SOURCE = from("typescript");
-  private static final JHipsterSource SOURCE_COMMON = from("client/common");
 
   public JHipsterModule buildModule(JHipsterModuleProperties properties) {
     Assert.notNull("properties", properties);
@@ -42,9 +41,6 @@ public JHipsterModule buildModule(JHipsterModuleProperties properties) {
         .addScript(scriptKey("watch:test"), scriptCommand("vitest --"))
         .and()
       .files()
-        .batch(SOURCE_COMMON, to("."))
-          .addFile(".npmrc")
-          .and()
         .batch(SOURCE, to("."))
           .addFile("tsconfig.json")
           .addTemplate("vitest.config.ts")

src/test/features/init.feature

@@ -12,6 +12,7 @@ Feature: Init
       | package.json      |
       | README.md         |
       | .lintstagedrc.cjs |
+      | .npmrc            |
     And I should not have files in ""
       | .prettierignore |
       | .prettierrc     |

src/test/java/tech/jhipster/lite/generator/client/angular/core/domain/AngularModuleFactoryTest.java

@@ -82,7 +82,6 @@ void shouldCreateAngularModule() {
         "tsconfig.app.json",
         "tsconfig.spec.json",
         "proxy.conf.json",
-        ".npmrc",
         "eslint.config.mjs"
       )
       .hasPrefixedFiles(

src/test/java/tech/jhipster/lite/generator/client/react/core/domain/ReactCoreModulesFactoryTest.java

@@ -69,7 +69,7 @@ void shouldBuildModuleWithStyle() {
         """
       )
       .and()
-      .hasFiles("tsconfig.json", "vite.config.ts", "vitest.config.ts", ".npmrc", "eslint.config.js")
+      .hasFiles("tsconfig.json", "vite.config.ts", "vitest.config.ts", "eslint.config.js")
       .hasFiles("src/main/webapp/index.html")
       .hasPrefixedFiles("src/main/webapp/app", "index.css", "index.tsx", "vite-env.d.ts")
       .hasFiles("src/test/webapp/unit/common/primary/app/App.spec.tsx")

src/test/java/tech/jhipster/lite/generator/init/domain/InitModuleFactoryTest.java

@@ -53,7 +53,8 @@ void shouldBuildModule() {
       .and()
       .hasFile(".lintstagedrc.cjs")
       .and()
-      .hasExecutableFiles(".husky/pre-commit");
+      .hasExecutableFiles(".husky/pre-commit")
+      .hasFile(".npmrc");
   }
 
   private JHipsterModuleProperties properties(String folder) {

src/test/java/tech/jhipster/lite/generator/typescript/domain/core/TypescriptModuleFactoryTest.java

@@ -43,6 +43,6 @@ void shouldCreateTypescriptModule() {
       .containing(nodeScript("watch:tsc", "tsc --noEmit --watch"))
       .containing(nodeScript("lint", "eslint ."))
       .and()
-      .hasPrefixedFiles("", ".npmrc", "eslint.config.js", "tsconfig.json");
+      .hasPrefixedFiles("", "eslint.config.js", "tsconfig.json");
   }
 }