Merge pull request #2200 from qmonmert/sonar-java-intellij

Clean code

src/main/java/tech/jhipster/lite/common/domain/Base64Utils.java

@@ -5,7 +5,7 @@
 
 public class Base64Utils {
 
-  private static SecureRandom random = new SecureRandom();
+  private static final SecureRandom random = new SecureRandom();
 
   private Base64Utils() {}
 

src/main/java/tech/jhipster/lite/generator/docker/infrastructure/secondary/FileSystemDockerImagesRepository.java

@@ -44,10 +44,7 @@ private Function<String, DockerImage> toDockerImage() {
     return line -> {
       int versionSeparatorIndex = line.lastIndexOf(":");
 
-      return new DockerImage(
-        line.substring(DOCKER_FROM.length(), versionSeparatorIndex),
-        line.substring(versionSeparatorIndex + 1, line.length())
-      );
+      return new DockerImage(line.substring(DOCKER_FROM.length(), versionSeparatorIndex), line.substring(versionSeparatorIndex + 1));
     };
   }
 }

src/main/java/tech/jhipster/lite/generator/history/infrastructure/primary/GeneratorHistoryInterceptor.java

@@ -17,7 +17,7 @@
 public class GeneratorHistoryInterceptor {
 
   private final GeneratorHistoryApplicationService generatorHistoryApplicationService;
-  private Clock clock;
+  private final Clock clock;
 
   public GeneratorHistoryInterceptor(GeneratorHistoryApplicationService generatorHistoryApplicationService, Clock clock) {
     this.generatorHistoryApplicationService = generatorHistoryApplicationService;

src/main/java/tech/jhipster/lite/generator/module/infrastructure/secondary/PropertiesFileSpringPropertiesHandler.java

@@ -49,7 +49,7 @@ private String buildProperties(PropertyKey key, PropertyValue value) throws IOEx
     int propertyIndex = currentProperties.indexOf(propertyId(key));
     if (propertyIndex != -1) {
       String start = currentProperties.substring(0, propertyIndex);
-      String end = currentProperties.substring(currentProperties.indexOf(BREAK, propertyIndex), currentProperties.length());
+      String end = currentProperties.substring(currentProperties.indexOf(BREAK, propertyIndex));
 
       return start + propertyLine(key, value) + end;
     }

src/main/java/tech/jhipster/lite/technical/infrastructure/primary/exception/ExceptionTranslator.java

@@ -44,7 +44,7 @@ public class ExceptionTranslator implements ProblemHandling {
   private boolean exceptionWithDetails;
 
   @Value("${application.exception.package}")
-  private List<String> packages = List.of();
+  private final List<String> packages = List.of();
 
   /**
    * Post-process the Problem payload to add the message key for the front-end if needed.