Merge pull request #11995 from qmonmert/varinstead3

Sonar: Local-Variable Type Inference should be used

src/main/resources/generator/server/springboot/cucumber/rest/CucumberRestTemplate.java.mustache

@@ -36,7 +36,7 @@ public class CucumberRestTemplate {
   }
 
   private HttpHeaders jsonHeaders() {
-    HttpHeaders headers = new HttpHeaders();
+    var headers = new HttpHeaders();
 
     headers.setAccept(List.of(MediaType.APPLICATION_JSON));
     headers.setContentType(MediaType.APPLICATION_JSON);

src/main/resources/generator/server/springboot/cucumber/rest/CucumberRestTestContext.java.mustache

@@ -194,7 +194,7 @@ public final class CucumberRestTestContext {
 
     private void retry() {
       try {
-        ClientHttpResponse clientHttpResponse = execution.execute(request, body);
+        var clientHttpResponse = execution.execute(request, body);
 
         CucumberRestTestContext.addResponse(request, clientHttpResponse, execution, body);
       } catch (IOException e) {

src/main/resources/generator/server/springboot/cucumber/rest/ElementAssertions.java.mustache

@@ -59,7 +59,7 @@ class ElementAssertions {
   <Data> void containing(List<Map<String, Data>> responses) {
     assertThat(responses).as("Can't check object against null responses").isNotNull();
 
-    for (int line = 0; line < responses.size(); line++) {
+    for (var line = 0; line < responses.size(); line++) {
       for (Map.Entry<String, Data> entry : responses.get(line).entrySet()) {
         String path = jsonPath + "[" + line + "]." + CucumberJson.toCamelCase(entry.getKey());
 

src/main/resources/generator/server/springboot/cucumberauthentication/jwt/AuthenticationSteps.java.mustache

@@ -43,7 +43,7 @@ public class AuthenticationSteps {
   private List<ClientHttpRequestInterceptor> interceptorsWithAuthentication(String user) {
     List<ClientHttpRequestInterceptor> interceptors = new ArrayList<>(rest.getRestTemplate().getInterceptors());
 
-    User userToAuthenticate = users.get(user);
+    var userToAuthenticate = users.get(user);
 
     assertThat(userToAuthenticate).as(unknownUserMessage(user)).isNotNull();
 

src/main/resources/generator/server/springboot/cucumberauthentication/oauth2/AuthenticationSteps.java.mustache

@@ -35,7 +35,7 @@ public class AuthenticationSteps {
   private List<ClientHttpRequestInterceptor> interceptorsWithAuthentication(String user) {
     List<ClientHttpRequestInterceptor> interceptors = new ArrayList<>(rest.getRestTemplate().getInterceptors());
 
-    User userToAuthenticate = users.get(user);
+    var userToAuthenticate = users.get(user);
 
     assertThat(userToAuthenticate).as(unknownUserMessage(user)).isNotNull();
 

src/main/resources/generator/server/springboot/dbmigration/liquibase/test/AsyncSpringLiquibaseTest.java.mustache

@@ -105,7 +105,7 @@ class AsyncSpringLiquibaseTest {
     @Test
     void shouldWarnWhenLiquibaseExecutionIsSlow() throws LiquibaseException {
       liquibaseProperties.setEnabled(true);
-      Duration slownessThreshold = Duration.ofMillis(50);
+      var slownessThreshold = Duration.ofMillis(50);
       TestAsyncSpringLiquibase asyncSpringLiquibase = spy(
         new TestAsyncSpringLiquibase(executor, environment, liquibaseProperties, slownessThreshold)
       );

src/main/resources/generator/server/springboot/mvc/security/jwt/authentication/test/application/AuthenticatedUserTest.java.mustache

@@ -106,7 +106,7 @@ class AuthenticatedUserTest {
 
   private static UsernamePasswordAuthenticationToken usernamePasswordAuthenticationToken() {
     Collection<GrantedAuthority> authorities = adminAuthorities();
-    User user = new User("admin", "admin", authorities);
+    var user = new User("admin", "admin", authorities);
 
     return new UsernamePasswordAuthenticationToken(user, "admin", authorities);
   }

src/main/resources/generator/server/springboot/mvc/security/oauth2/core/main/infrastructure/primary/CustomClaimConverter.java.mustache

@@ -75,7 +75,7 @@ class CustomClaimConverter implements Converter<Map<String, Object>, Map<String,
   }
 
   private ObjectNode loadUser(ClientRegistration registration, RestTemplate restTemplate, SubAttributes subAttributes) {
-    HttpHeaders headers = new HttpHeaders();
+    var headers = new HttpHeaders();
     headers.set(HttpHeaders.AUTHORIZATION, buildBearer(getToken(subAttributes.attributes)));
 
     ResponseEntity<ObjectNode> userInfo = restTemplate.exchange(

src/main/resources/generator/server/springboot/mvc/security/oauth2/core/test/application/AuthenticatedUserTest.java.mustache

@@ -185,7 +185,7 @@ class AuthenticatedUserTest {
 
   private static UsernamePasswordAuthenticationToken usernamePasswordAuthenticationToken() {
     Collection<GrantedAuthority> authorities = adminAuthorities();
-    User user = new User("admin", "admin", authorities);
+    var user = new User("admin", "admin", authorities);
 
     return new UsernamePasswordAuthenticationToken(user, "admin", authorities);
   }

src/main/resources/generator/server/springboot/webflux/web/main/HeaderUtil.java.mustache

@@ -29,7 +29,7 @@ public final class HeaderUtil {
     String message = "error." + errorKey;
     log.error("Entity processing failed, {}", message);
 
-    HttpHeaders headers = new HttpHeaders();
+    var headers = new HttpHeaders();
     headers.add("X-" + applicationName + "-error", message);
     headers.add("X-" + applicationName + "-params", entityName);
     

src/test/java/tech/jhipster/lite/cucumber/rest/CucumberRestTestContext.java

@@ -200,7 +200,7 @@ private boolean forUri(String uri) {
 
     private void retry() {
       try {
-        ClientHttpResponse clientHttpResponse = execution.execute(request, body);
+        var clientHttpResponse = execution.execute(request, body);
 
         addResponse(request, clientHttpResponse, execution, body);
       } catch (IOException e) {

src/test/java/tech/jhipster/lite/cucumber/rest/ElementAssertions.java

@@ -60,7 +60,7 @@ void withMoreThanElementsCount(int count) {
   <Data> void containing(List<Map<String, Data>> responses) {
     assertThat(responses).as("Can't check object against null responses").isNotNull();
 
-    for (int line = 0; line < responses.size(); line++) {
+    for (var line = 0; line < responses.size(); line++) {
       for (Map.Entry<String, Data> entry : responses.get(line).entrySet()) {
         String path = jsonPath + "[" + line + "]." + CucumberJson.toCamelCase(entry.getKey());
 

src/test/java/tech/jhipster/lite/module/infrastructure/primary/ModulesSteps.java

@@ -229,7 +229,7 @@ private void post(String uri, String content) {
   }
 
   private HttpHeaders jsonHeaders() {
-    HttpHeaders headers = new HttpHeaders();
+    var headers = new HttpHeaders();
 
     headers.setAccept(List.of(MediaType.APPLICATION_JSON));
     headers.setContentType(MediaType.APPLICATION_JSON);

src/test/java/tech/jhipster/lite/project/infrastructure/primary/ProjectsSteps.java

@@ -32,7 +32,7 @@ public void downloadCreatedProject() {
   }
 
   private HttpHeaders octetsHeaders() {
-    HttpHeaders headers = new HttpHeaders();
+    var headers = new HttpHeaders();
 
     headers.setAccept(List.of(MediaType.APPLICATION_OCTET_STREAM));
     headers.setContentType(MediaType.APPLICATION_OCTET_STREAM);
@@ -51,7 +51,7 @@ public void getCreatedProjectInformation() {
   }
 
   private HttpHeaders jsonHeaders() {
-    HttpHeaders headers = new HttpHeaders();
+    var headers = new HttpHeaders();
 
     headers.setAccept(List.of(MediaType.APPLICATION_JSON));
     headers.setContentType(MediaType.APPLICATION_JSON);