Add customizable border radius to progressbar #2224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a improvement.
$radius-rounded
is not meant to be modified and is used directly to style progress bars. We need a dedicated variable to override this style if needed.Proposed solution
Add
$progress-border-radius
intosass/elements/progress.sass
with$radius-rounded
as default value.Tradeoffs
None
Testing Done
For each test.
Defined
$progress-border-radius
to some values (px/rem/%), then imported bulma.Checked the border-radius, with built css file, over progress element : ok.
Did the same with jekyll for the docs.