Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizable border radius to progressbar #2224

Merged
merged 2 commits into from
May 17, 2019
Merged

Conversation

Come2Daddy
Copy link
Contributor

This is a improvement.

$radius-rounded is not meant to be modified and is used directly to style progress bars. We need a dedicated variable to override this style if needed.

Proposed solution

Add $progress-border-radius into sass/elements/progress.sass with $radius-rounded as default value.

Tradeoffs

None

Testing Done

For each test.
Defined $progress-border-radius to some values (px/rem/%), then imported bulma.
Checked the border-radius, with built css file, over progress element : ok.

Did the same with jekyll for the docs.

@jgthms jgthms merged commit 99aeecc into jgthms:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants