Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set navbar hamburger color to match items and allow manual setting
This is a new feature.
Proposed solution
This patch is a new feature to accommodate the request in #1875. The issue has a request for sizing classes on the the
.buttons
and.tags
elements. This PR adds that feature by addingare-medium
andare-large
classes to the tag.sass file andare-small
,are-medium
, andare-large
classes to the button.sass file.Tradeoffs
Using the sizing classes on the
.tags
or.buttons
elements removes the ability to size the children individually. For instance, if you used.are-medium
on the parent element and then tried to give one of the children.is-small
, it wouldn't apply the.is-small
styling.If the user wishes to have differently sized buttons, they will have to add the desired sizing class to each
.button
element. This would be no different than how they currently have to size buttons differently.Testing Done
I have tested this feature locally with a basic html document which uses Bulma.