Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #1875 #1959

Closed
wants to merge 2 commits into from
Closed

Fixes Issue #1875 #1959

wants to merge 2 commits into from

Conversation

iamtimsmith
Copy link

Set navbar hamburger color to match items and allow manual setting

This is a new feature.

Proposed solution

This patch is a new feature to accommodate the request in #1875. The issue has a request for sizing classes on the the .buttons and .tags elements. This PR adds that feature by adding are-medium and are-large classes to the tag.sass file and are-small, are-medium, and are-large classes to the button.sass file.

Tradeoffs

Using the sizing classes on the .tags or .buttons elements removes the ability to size the children individually. For instance, if you used .are-medium on the parent element and then tried to give one of the children .is-small, it wouldn't apply the .is-small styling.

If the user wishes to have differently sized buttons, they will have to add the desired sizing class to each .button element. This would be no different than how they currently have to size buttons differently.

Testing Done

I have tested this feature locally with a basic html document which uses Bulma.

…e-small, are-medium, and are-large classes for buttons.
@jgthms
Copy link
Owner

jgthms commented Oct 7, 2018

This looks good. Can you remove the generated CSS though?

@diomed
Copy link
Contributor

diomed commented Oct 25, 2018

I'm thinking of hijacking this if @iamtimsmith doesn't resolve conflicts and change anything by the end of the weekend.

@jgthms
Copy link
Owner

jgthms commented Oct 25, 2018

No problem @diomed

@iamtimsmith
Copy link
Author

@jgthms I have removed the generated CSS and updated the PR.

@jgthms
Copy link
Owner

jgthms commented Oct 26, 2018

It doesn't seem to have worked 🤔

@jgthms
Copy link
Owner

jgthms commented Oct 31, 2018

Closed by #2201

@jgthms jgthms closed this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants