Fix navbar-burger sample code in navbar.html #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<button> elements with the class combination of button and navbar-burger display with a border. Updating to divs and removing button class
|
Good job! I think @jgthms will merge it before doing a release. |
|
Thank you! Hope it helps. |
feute
suggested changes
Dec 24, 2017
Fixing button ending tags based on suggestion from @feute
|
Great catch, thanks @feute ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a documentation fix.
Proposed solution
button elements with the class combination of 'button' and 'navbar-burger' display with a border. Updating the buttons in the documentation to divs, and removing button class.
Other parts of the documentation, as well as the documentation site itself, use a div with class="navbar-burger" instead of a button. Normalizing the examples so others don't experience the same headache that I did from using html button and classes as presented in the docs :)