Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example about Twitter #2862

Closed
MokkeMeguru opened this issue Mar 1, 2020 · 4 comments
Closed

Fix example about Twitter #2862

MokkeMeguru opened this issue Mar 1, 2020 · 4 comments

Comments

@MokkeMeguru
Copy link

This is about the Docs.

Overview of the problem

The Twitter brand guideline says We cannot use the "Twitter icon" with "Twitter Text".

https://about.twitter.com/content/dam/about-twitter/company/brand-resources/en_us/Twitter_Brand_Guidelines_V2_0.pdf

But you show an example of it.
https://bulma.io/documentation/elements/button/

This example leads us to do violating usage.
Can you fix it?

@fmmricardo
Copy link
Contributor

fmmricardo commented Mar 13, 2020

Hi @MokkeMeguru, what would be the best solution here, keep the twitter icon or the text?
I can help on trying to fix this issue but I need the opinion from someone from bulma, to decide what would be the best option.

@MokkeMeguru
Copy link
Author

I think, we should update,

  <button class="button is-primary">
    <span class="icon">
      <i class="fab fa-twitter"></i>
    </span>
    <span>Twitter</span>
  </button>

to

  <button class="button is-primary">
    <span class="icon">
      <i class="fab fa-twitter"></i>
    </span>
    <span>@Bluma</span>
  </button>

This will not violate the Twitter's terms !

fmmricardo pushed a commit to fmmricardo/bulma that referenced this issue Mar 14, 2020
Why:

* According Twitter brand guideline says we cannot use the "Twitter icon" with "Twitter text".

This change addresses the need by:

* Replacing the span text from Twitter for @bulma
fmmricardo added a commit to fmmricardo/bulma that referenced this issue Mar 14, 2020
@fmmricardo
Copy link
Contributor

fmmricardo commented Mar 14, 2020

@MokkeMeguru - #2874

@MokkeMeguru
Copy link
Author

Thanks for your works!

@jgthms jgthms closed this as completed in 4b2bc00 Mar 15, 2020
jgthms pushed a commit that referenced this issue Mar 23, 2020
* Fixes #2862

Why:

* According Twitter brand guideline says we cannot use the "Twitter icon" with "Twitter text".

This change addresses the need by:

* Replacing the span text from Twitter for @bulma

* Updates button text

Changes @bulma to @jgthms

Co-authored-by: Ricardo Martins (ext.) <Ricardo.Martins@ctw.bmwgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants