Replace polyfill provider #9537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgm
reviewed
Mar 1, 2024
| @@ -27,8 +27,7 @@ $for(header-includes)$ | |||
| $header-includes$ | |||
| $endfor$ | |||
| $if(math)$ | |||
| $if(mathjax)$ | |||
| <script src="https://polyfill.io/v3/polyfill.min.js?features=es6"></script> | |||
| $if(mathjax)$https://cdnjs.cloudflare.com/polyfill/v3/polyfill.min.js?features=es6"></script> | |||
There was a problem hiding this comment.
This doesn't look right. Isn't the <script part missing? And a newline? Shouldn't it be like the html4 template?
There was a problem hiding this comment.
I'll just make the commit directly because it's clear what is needed.
|
Thank you for this! I've made the change and will push it directly, crediting you. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polyfill.iowas inttroduced by @tarleb in #7838.The PR replaces
polyfill.iowithcdnjs.cloudflare.com/polyfillpolyfill.iowas acquired by a China-based CDN company "Funnull", see the announcement from thepolyfill.iodomain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.The original creator of the
polyfill.iohas voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, AlistGo/alist#6100), rendering thepolyfill.ioservice extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances ofpolyfill.ioservice.