Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Dockerfile to use crystal 1.12.1 #3

Merged
merged 1 commit into from
Apr 28, 2024
Merged

chore: Update Dockerfile to use crystal 1.12.1 #3

merged 1 commit into from
Apr 28, 2024

Conversation

miry
Copy link
Contributor

@miry miry commented Apr 28, 2024

Update Dockerfile to have latest crystal and minor changes.

@miry
chore: Update Dockerfile to use crystal 1.12.1
b2ad86e 
Update Dockerfile to have latest crystal and minor changes.
@miry miry force-pushed the update-crystal-version branch from d3056e1 to b2ad86e Compare April 28, 2024 13:26
@miry miry changed the title Update Dockerfile to use crystal 1.12.1 chore: Update Dockerfile to use crystal 1.12.1 Apr 28, 2024
jgaskins
jgaskins approved these changes Apr 28, 2024
View reviewed changes
Copy link
Owner

@jgaskins jgaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is one of the hard parts about upgrading Crystal. 😄 I've thought about using latest-alpine, but then the container images break randomly and it's hard to know which version of Crystal a given image is built against.

@jgaskins jgaskins merged commit 10bed92 into jgaskins:main Apr 28, 2024
@miry miry deleted the update-crystal-version branch April 28, 2024 18:18
@miry
Copy link
Contributor Author

miry commented Apr 28, 2024 •
edited
Loading

@jgaskins I can add github action with dependa bot, like "we" like :)

@jgaskins
Copy link
Owner

lol Does Dependabot track container dependencies?

@miry
Copy link
Contributor Author

miry commented Apr 28, 2024 •
edited
Loading

Yep, for sure it can upgrade FROM,
but also if I am not wrong, it could upgrade specific version of package if it was specified explictly.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/about-dependabot-version-updates#supported-repositories-and-ecosystems

Example: opentracing-contrib/nginx-opentracing#605

@jgaskins
Copy link
Owner

TIL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgaskins jgaskins jgaskins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miry @jgaskins