Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to close response body before status check #965

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

nakabonne
Copy link
Contributor

httpclient.HttpClient.UploadFileFromReader() used to not to close the HTTP response body when the status code is unexpected. The defer block for this should be appended right after the HTTP call is made.

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nakabonne
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sverdlov93 sverdlov93 added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jun 25, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 25, 2024
@sverdlov93
Copy link
Contributor

Hi @nakabonne, Thanks for your contribution!

@sverdlov93 sverdlov93 merged commit 9aa6bfa into jfrog:dev Jun 25, 2024
28 of 30 checks passed
@nakabonne
Copy link
Contributor Author

@sverdlov93 Thank you for your quick review! We're stuck with the goroutine leak issue because of this. Can you estimate approximately when this will be released?

@sverdlov93
Copy link
Contributor

Hi @nakabonne,

Do you need this as part of the JFrog CLI, or do you use jfrog-client-go as a dependency?

@nakabonne
Copy link
Contributor Author

@sverdlov93 We use jfrog-client-go as a dependency in our Go project.

@sverdlov93
Copy link
Contributor

@nakabonne Its released! Thanks again for your contribution!

@nakabonne
Copy link
Contributor Author

Thank you for the quick release and for maintaining this project!

@nakabonne nakabonne deleted the fix-goroutine-leak branch June 28, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants