Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock dry run deletion success #922

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Mock dry run deletion success #922

merged 2 commits into from
Mar 13, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Mar 12, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

rt delete --dry-run mock deletion success to avoid failure

image

before:
image

will fix the following CLI issues:
jfrog/jfrog-cli#682
jfrog/jfrog-cli#1794

@EyalDelarea EyalDelarea added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Mar 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@EyalDelarea EyalDelarea marked this pull request as ready for review March 12, 2024 15:06
@EyalDelarea EyalDelarea requested a review from sverdlov93 March 12, 2024 15:09
@EyalDelarea EyalDelarea changed the title rt delete --dry-run mock success Mock dry run deletion success Mar 13, 2024
@EyalDelarea EyalDelarea merged commit 393125c into jfrog:dev Mar 13, 2024
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyalDelarea @sverdlov93