Update XscGitInfoContext struct #1089
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
4 tasks
attiasas
reviewed
Feb 25, 2025
| type PullRequestContext struct { | ||
| PullRequestId int `json:"pull_request_id,omitempty"` | ||
| PullRequestTitle string `json:"pull_request_title,omitempty"` | ||
| TargetBranchName string `json:"target_branch_name,omitempty"` |
There was a problem hiding this comment.
I would extract this variable from this struct to stand at XscGitInfoContext as: Target *CommitContext
If we will want more information about the branch it will be a breaking changes at the current state.
| requestContent, err := json.Marshal(event) | ||
| if err != nil { | ||
| return "", errorutils.CheckError(err) | ||
| func (vs *AnalyticsEventService) AddGeneralEvent(event XscAnalyticsGeneralEvent, xrayVersion string) (string, error) { |
There was a problem hiding this comment.
you can also detect the version instead of getting the version as arg if you want:
xrayVersion, err := xrDetails.GetVersion()
if err != nil {
return errors.New("Couldn't get Xray version. Error: " + err.Error())
}
There was a problem hiding this comment.
I first tried this option but had two thoughts:
- I think there’s no reason to make another API call if we already have this information.
- In cases when a user is using the xsc-service before it became part of Xray, the vs.XrayDetails.GetVersion() will be nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AddGeneralEvent and XscGitInfoContext structs due to changes done in XSC (as part of PR view epic).
The new XscGitInfoStruct should look like this: