-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rt curl
ServerID environment variable usage
#2882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
dff6ee6
to
ad805fa
Compare
EyalDelarea
requested changes
Feb 26, 2025
ad805fa
to
ccf411f
Compare
EyalDelarea
approved these changes
Feb 26, 2025
rt curl
ServerID environment variable usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.Fix: Ensure jfrog rt curl Uses
JFROG_CLI_SERVER_ID
When SetIssue
Currently, jfrog rt curl does not respect the
JFROG_CLI_SERVER_ID
environment variable when no--server-id
flag is provided. Instead, it always defaults to the server configured via jfrog c add. This PR addresses issue #2870.Changes Made
JFROG_CLI_SERVER_ID
when--server-id
is not explicitly set.--server-id
flag takes precedence overJFROG_CLI_SERVER_ID
.JFROG_CLI_SERVER_ID
takes precedence over the default configuration.Impact
JFROG_CLI_SERVER_ID
.Testing