Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide deprecated commands from help section #2439

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Hide deprecated commands from help section #2439

merged 2 commits into from
Feb 18, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Feb 15, 2024 •
edited by attiasas
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Security content moved to: https://github.com/jfrog/jfrog-cli-security/tree/main/cli/docs

@sverdlov93
empty archive
ebbd80c 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 requested review from yahavi and eyalbe4 February 15, 2024 11:09
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Feb 15, 2024
@sverdlov93
empty archive
48afc79 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Feb 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 15, 2024
yahavi
yahavi requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure if this PR accomplishes its intended goal. I do see the commands displayed when running jf rt -h. Can you confirm if it's working properly?

@sverdlov93
Copy link
Contributor Author

currently won't work due to urfave/cli#1860
@yahavi

@sverdlov93 sverdlov93 merged commit 21bd9ea into jfrog:dev Feb 18, 2024
62 of 63 checks passed
@sverdlov93 sverdlov93 added the ignore for release Automatically generated release notes label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @yahavi