Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload empty archive when all upload files were filtered out #2432

Merged
merged 11 commits into from
Feb 14, 2024

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Feb 8, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

We added the option to set the following env JFROG_CLI_UPLOAD_EMPTY_ARCHIVE for the following scenario:

  1. JFrog CLI upload command
  2. The --archive flag is set
  3. The --exclusion is set and all files are being excluded by the exclusion pattern

The default behavior is to upload nothing.
The behavior with the new env it to upload an empty archive.

depends on jfrog/jfrog-cli-core#1124 and jfrog/jfrog-client-go#899

Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Feb 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 8, 2024
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Feb 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 8, 2024
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Feb 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 8, 2024
@sverdlov93 sverdlov93 added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Feb 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 8, 2024
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Feb 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 14, 2024
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Feb 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 14, 2024
@sverdlov93 sverdlov93 merged commit 073387d into jfrog:dev Feb 14, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant