Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to get SBOM information #307

Merged
merged 16 commits into from
Feb 25, 2025
Merged

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Feb 16, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Add new flag --sbom to our scan commands.
If this flag is included with sca scan and table format, it will display the SBOM that was scanned.

image

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 17, 2025
@attiasas attiasas added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Feb 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 17, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 17, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 17, 2025
@attiasas attiasas marked this pull request as ready for review February 18, 2025 08:35
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2025
Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 19, 2025
@attiasas attiasas changed the title Audit - Add option to get SBOM information Add option to get SBOM information Feb 23, 2025
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Feb 23, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 23, 2025
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/cli 0.00% (ø)
github.com/jfrog/jfrog-cli-security/cli/docs 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/enrich 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/git/audit 0.00% (ø)
github.com/jfrog/jfrog-cli-security/commands/scan 0.00% (ø)
github.com/jfrog/jfrog-cli-security/jas/runner 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/formats 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/conversion 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/conversion/simplejsonparser 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/conversion/summaryparser 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/conversion/tableparser 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/output 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/validations 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/xsc 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/cli/docs/flags.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/cli/scancommands.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/audit/audit.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/audit/scarunner.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/enrich/enrich.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/git/audit/gitaudit.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/scan/buildscan.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/commands/scan/scan.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/formats/table.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/common.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/conversion/convertor.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser/sarifparser.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/conversion/simplejsonparser/simplejsonparser.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/conversion/summaryparser/summaryparser.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/conversion/tableparser/tableparser.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/output/resultwriter.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/results.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/validations/test_validate_sca.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/validations/test_validation.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/commands/audit/audit_test.go
  • github.com/jfrog/jfrog-cli-security/jas/runner/jasrunner_test.go
  • github.com/jfrog/jfrog-cli-security/utils/results/common_test.go
  • github.com/jfrog/jfrog-cli-security/utils/results/conversion/convertor_test.go
  • github.com/jfrog/jfrog-cli-security/utils/xsc/analyticsmetrics_test.go

Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit ccd59bf into jfrog:dev Feb 25, 2025
9 checks passed
@attiasas attiasas deleted the audit_sbom_out branch February 25, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants