Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operational risks results duplications in Table format - Bug fix #298

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jan 30, 2025

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This PR fixes a bug in Operation risks results in a Table format.
The bug caused each result to be duplicated as the amount of characters in the name of the impacted dependency.
After removing the redundant loop the issue is resolved.
Screenshot 2025-01-30 at 17 10 20

@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jan 30, 2025
@eranturgeman eranturgeman requested a review from attiasas January 30, 2025 14:51
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 30, 2025
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 30, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 30, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…o operational-risks-results-duplication-bug-fix
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 2, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 2, 2025
Copy link

github-actions bot commented Feb 2, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

github-actions bot commented Feb 2, 2025

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/utils/results/conversion/simplejsonparser 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/utils/results/conversion/simplejsonparser/simplejsonparser.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@eranturgeman eranturgeman merged commit 462ab39 into jfrog:dev Feb 2, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants