Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build info collection support for Terraform #661

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Add build info collection support for Terraform #661

merged 4 commits into from
Jan 3, 2023

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Jan 3, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Depends on jfrog/build-info-go#121

@RobiNino RobiNino added the improvement Automatically generated release notes label Jan 3, 2023
@RobiNino RobiNino requested a review from eyalbe4 January 3, 2023 11:05
@RobiNino RobiNino temporarily deployed to frogbot January 3, 2023 11:05 — with GitHub Actions Inactive
@RobiNino RobiNino mentioned this pull request Jan 3, 2023
Merged
4 tasks
@eyalbe4 eyalbe4 added the new feature Automatically generated release notes label Jan 3, 2023
@eyalbe4 eyalbe4 changed the title Add build info collection support for Terraform Bbuild info collection support for Terraform Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

What is Frogbot?

@RobiNino RobiNino changed the title Bbuild info collection support for Terraform Add build info collection support for Terraform Jan 3, 2023
eyalbe4
eyalbe4 suggested changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make aure the tests static analysis are green,

@RobiNino RobiNino merged commit 15bc81e into jfrog:dev Jan 3, 2023
@RobiNino RobiNino mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @eyalbe4