Publish multiple npm workspaces packages #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverdlov93
reviewed
Mar 6, 2024
| output = strings.TrimSpace(output) | ||
| lines := strings.Split(output, "\n") | ||
| return strings.TrimSpace(lines[len(lines)-1]), nil | ||
| return strings.Split(output, "\n") |
There was a problem hiding this comment.
Looks like from the CLI test that it is working on windows 👍
…blish-multiple-npm-packages
…blish-multiple-npm-packages
EyalDelarea
commented
Mar 11, 2024
artifactory/utils/npm/pack_test.go
Outdated
There was a problem hiding this comment.
I've removed this test as the test case was irrelevant.
We checked the whole output of the CMD and tried to extract the tar.gz file name, as in practice, the npm cmd already gives us the name. and all we have to do now is to split the file names if we have more then one.
I've deleted the test here, and added a full test in CLI side to publish multiple packages.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
jf npm publishcommand the core didn't address the--workspacesflag which indices that there are multiple modules inside the current project.This PR fixes the publish command to handle more than one module if exists and combine the results.
example package.json workspaces defined:
Before:
After:
Should fix the following issue:
jfrog/jfrog-azure-devops-extension#473