Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join error on GetRepoConfigByPrefix #1117

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Join error on GetRepoConfigByPrefix #1117

merged 2 commits into from
Jan 25, 2024

Conversation

attiasas
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

When refactoring the code to another location GetRepoConfigByPrefix was changed and did not join the errors by mistake.
8e451d1#diff-374058d0b4f3d0f1fc734af2925a8e92e53a4f18e4372f5f7b34cf3864f5c6fcL129
return the join for the errors.

@attiasas attiasas added the bug Something isn't working label Jan 25, 2024
@attiasas attiasas marked this pull request as ready for review January 25, 2024 11:16
@attiasas attiasas changed the title join error on GetRepoConfigByPrefix Join error on GetRepoConfigByPrefix Jan 25, 2024
@attiasas attiasas requested a review from yahavi January 25, 2024 11:21
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@attiasas attiasas merged commit 6997ffa into jfrog:dev Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants