Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Validation for Supported Yarn Versions #44

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

fluxxBot
Copy link
Collaborator

@fluxxBot fluxxBot commented Feb 10, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

depends on:

  1. Verify supported Yarn version jfrog-cli-core#1347

@fluxxBot fluxxBot requested a review from bhanurp February 10, 2025 12:30
Copy link

github-actions bot commented Feb 10, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@fluxxBot
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@fluxxBot
Copy link
Collaborator Author

  1. Added error message when user trying to upgrade to v4 in yarn
  2. Allowed user to change the version irrespective of which version being currently used
  3. Allowed user to check version irrespective of which version being currently used
  4. Added check when a user tries to fetch config get which returns undefined in the newer yarn version
  5. Prevents user from switching to version v4 of yarn

@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 11, 2025
@EyalDelarea
Copy link

Hey @fluxxBot,

I've added my review, please let's also update the title of the PR as we would expect it to appear in the release notes.

Something like :Introduce Validation for Supported Yarn Versions
which in my opinion better describe the new code that is being added here.

Let me know what you think 👍

@fluxxBot fluxxBot changed the title Restrict user from using yarn v4 Introduce Validation for Supported Yarn Versions Feb 18, 2025
@fluxxBot fluxxBot force-pushed the main branch 9 times, most recently from 4932564 to 4e7e554 Compare February 20, 2025 12:24
@fluxxBot fluxxBot requested a review from EyalDelarea February 21, 2025 06:05
@fluxxBot fluxxBot force-pushed the main branch 2 times, most recently from c1bb2d8 to ea72717 Compare February 21, 2025 09:03
@fluxxBot fluxxBot merged commit 0588953 into jfrog:main Feb 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes safe to test Approve running integration tests on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants