Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan fails upon empty PR push #631

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jan 31, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR fixes failure in scan-repository (separate PRs for each vulnerability) when there is nothing to push after the fix in some vulnerability (this can happen when there is no fix branch and Frogbot cannot fix the vulnerability)

@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jan 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 31, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 31, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 31, 2024
@eranturgeman eranturgeman requested a review from omerzi February 1, 2024 07:31
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 1, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Feb 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@eranturgeman eranturgeman changed the title Scan fails upon empty PR push fix Scan fails upon empty PR push Feb 1, 2024
@eranturgeman eranturgeman merged commit 207f42f into jfrog:dev Feb 1, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants