Added matchers .toBeCloseTo and .toMatch #1277
Conversation
|
Please rebase :) |
0d1052c to
2a701fb
Compare
|
@cpojer done 😊 |
|
Seems like there are some failures on travis? |
| if ( | ||
| !(typeof expected === 'string') && | ||
| !(Object.prototype.toString.call(expected) === '[object RegExp]') | ||
| ) { |
There was a problem hiding this comment.
@cpojer do you have any idea why the first variant might fail for some cases? In dev tools for the case
expect(diff('a', 'a')).toMatch(/no visual difference/);expected.constructor prints [Function: RegExp] but expected.constructor === RegExp is false.
There was a problem hiding this comment.
#1275
that should fix it
There was a problem hiding this comment.
got it 👍
rebased and revoked this fix
There was a problem hiding this comment.
thanks! sorry you had to go through this :)
2e35a6e to
4ee552a
Compare
| @@ -109,6 +109,35 @@ const matchers: MatchersObject = { | |||
| `'${expected}' (using <=)`; | |||
| return {message, pass}; | |||
| }, | |||
|
|
|||
| toBeCloseTo(actual: number, expected: number, precision: number) { | |||
There was a problem hiding this comment.
should probably be precision?: number, because it's optional
070a1cb to
e223d2b
Compare
e223d2b to
47d78ec
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.