Remove check for per-comparator call detach check in TypedArray.proto…

…type.sort This updates tests in line with the normative change in tc39/ecma262#2723
jessealama · Apr 5, 2022 · d7c0a20 · d7c0a20
1 parent 3ac6b73
commit d7c0a20
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 130 deletions.
diff --git a/test/built-ins/TypedArray/prototype/sort/BigInt/detached-buffer-comparefn.js b/test/built-ins/TypedArray/prototype/sort/BigInt/detached-buffer-comparefn.js
diff --git a/test/built-ins/TypedArray/prototype/sort/detached-buffer-comparefn-coerce.js b/test/built-ins/TypedArray/prototype/sort/detached-buffer-comparefn-coerce.js
diff --git a/test/built-ins/TypedArray/prototype/sort/detached-buffer-comparefn.js b/test/built-ins/TypedArray/prototype/sort/detached-buffer-comparefn.js
diff --git a/test/built-ins/TypedArray/prototype/sort/sort-tonumber.js b/test/built-ins/TypedArray/prototype/sort/sort-tonumber.js
@@ -21,16 +21,12 @@ testWithTypedArrayConstructors(function(TA) {
   var ab = ta.buffer;
 
   var called = false;
-  assert.throws(TypeError, function() {
-    ta.sort(function(a, b) {
-      // IsDetachedBuffer is checked right after calling comparefn.
-      // So, detach the ArrayBuffer to cause sort to throw, to make sure we're actually calling ToNumber immediately (as spec'd)
-      // (a possible bug is to wait until the result is inspected to call ToNumber, rather than immediately)
-      $DETACHBUFFER(ab);
-      return {
-        [Symbol.toPrimitive]() { called = true; }
-      };
-    });
+  ta.sort(function(a, b) {
+    // Detaching the buffer does not cause sort to throw.
+    $DETACHBUFFER(ab);
+    return {
+      [Symbol.toPrimitive]() { called = true; }
+    };
   });
 
   assert.sameValue(true, called);