Temporal: Some more tests for PlainDateTime.compare.

jessealama · Apr 12, 2022 · 2c880bf · 2c880bf
1 parent a226601
commit 2c880bf
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 16 deletions.
diff --git a/test/built-ins/Temporal/PlainDateTime/compare/basic.js b/test/built-ins/Temporal/PlainDateTime/compare/basic.js
@@ -9,21 +9,14 @@ features: [Temporal]
 
 const dt1 = new Temporal.PlainDateTime(1976, 11, 18, 15, 23, 30, 123, 456, 789);
 const dt2 = new Temporal.PlainDateTime(2019, 10, 29, 10, 46, 38, 271, 986, 102);
+const dt3 = new Temporal.PlainDateTime(2019, 10, 29, 10, 46, 38, 271, 986, 102);
+const dt4 = new Temporal.PlainDateTime(2019, 10, 29, 15, 23, 30, 123, 456, 789);
+const dt5 = new Temporal.PlainDateTime(1976, 11, 18, 10, 46, 38, 271, 986, 102);
 
-assert.sameValue(
-  Temporal.PlainDateTime.compare(dt1, dt1),
-  0,
-  "equal"
-);
+assert.sameValue(Temporal.PlainDateTime.compare(dt1, dt1), 0, "equal");
+assert.sameValue(Temporal.PlainDateTime.compare(dt1, dt2), -1, "smaller/larger");
+assert.sameValue(Temporal.PlainDateTime.compare(dt2, dt1), 1, "larger/smaller");
+assert.sameValue(Temporal.PlainDateTime.compare(dt2, dt3), 0, "equal different object");
+assert.sameValue(Temporal.PlainDateTime.compare(dt3, dt4), -1, "same date, earlier time");
+assert.sameValue(Temporal.PlainDateTime.compare(dt3, dt5), 1, "same time, later date");
 
-assert.sameValue(
-  Temporal.PlainDateTime.compare(dt1, dt2),
-  -1,
-  "smaller/larger"
-);
-
-assert.sameValue(
-  Temporal.PlainDateTime.compare(dt2, dt1),
-  1,
-  "larger/smaller"
-);
diff --git a/test/built-ins/Temporal/PlainDateTime/compare/calendar-ignored.js b/test/built-ins/Temporal/PlainDateTime/compare/calendar-ignored.js
@@ -0,0 +1,19 @@
+// Copyright (C) 2022 Igalia, S.L. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-temporal.plaindatetime.compare
+description: Calendar is not taken into account for the comparison.
+features: [Temporal]
+---*/
+
+const calendar1 = { toString() { throw new Test262Error("should not call calendar1.toString") } };
+const calendar2 = { toString() { throw new Test262Error("should not call calendar2.toString") } };
+const dt1 = new Temporal.PlainDateTime(1976, 11, 18, 15, 23, 30, 123, 456, 789, calendar1);
+const dt2 = new Temporal.PlainDateTime(2019, 10, 29, 10, 46, 38, 271, 986, 102, calendar1);
+const dt3 = new Temporal.PlainDateTime(2019, 10, 29, 10, 46, 38, 271, 986, 102, calendar1);
+const dt4 = new Temporal.PlainDateTime(2019, 10, 29, 10, 46, 38, 271, 986, 102, calendar2);
+
+assert.sameValue(Temporal.PlainDateTime.compare(dt1, dt2), -1, "smaller");
+assert.sameValue(Temporal.PlainDateTime.compare(dt2, dt3), 0, "equal with same calendar");
+assert.sameValue(Temporal.PlainDateTime.compare(dt2, dt4), 0, "equal with different calendar");