Improve Js2C converter #1408
Merged
Improve Js2C converter #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galpeter
reviewed
Oct 26, 2016
| @@ -122,7 +127,7 @@ def exportOneFile(path, name): | |||
| def exportOneName(name): | |||
| writeLine(fout, '{ ' + name + '_n, ' + name + '_s, ' + name + '_l }, \\', 1) | |||
|
|
|||
| files = glob.glob(SRC_PATH + '*.js') | |||
| files = glob.glob(SRC_PATH + '/*.js') | |||
There was a problem hiding this comment.
This could also be joined (os.path.join) together.
| OUT_PATH = './source/' | ||
| SRC_PATH = './js/' | ||
| OUT_PATH = './source' | ||
| SRC_PATH = './js' |
There was a problem hiding this comment.
I see no point having this, just move them into the add_argument call.
|
|
||
| import argparse | ||
| from os import path |
There was a problem hiding this comment.
We could simply use: os.path.join then there is no need for this import :)
4bc953f to
42e5ce1
Compare
|
@galpeter, thanks for the review. I've updated the PR. |
* Rename 'jerry_targetjs.h' to 'jerry-targetjs.h', because we use dashes in filen ames instead of underscores. * Made destination and js souce directory configurable. * Updated esp8266 target to the recent changes. * Updated mbed and mbedos5 target to the recent changes. JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com
42e5ce1 to
b23b991
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because we use dashes in file names instead of underscores.
JerryScript-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com