-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Set board as generic if not defined #1943
build: Set board as generic if not defined #1943
Conversation
Observed issue using cmake: CMake Error at CMakeLists.txt:136 (string): string no output variable specified This will help to keep iotjs in debian repo. Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: jerryscript-project#1943 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
ff27c37
to
3f7b386
Compare
Observed issue using cmake: CMake Error at CMakeLists.txt:136 (string): string no output variable specified This will help to keep iotjs in debian repo. Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: jerryscript-project#1943 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is verified at: https://travis-ci.org/github/jerryscript-project/iotjs/builds/711220082 |
Observed issue using cmake: CMake Error at CMakeLists.txt:136 (string): string no output variable specified This will help to keep iotjs in debian repo. Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050 Forwarded: jerryscript-project#1943 Bug: jerryscript-project#1945 Bug-Debian: https://bugs.debian.org/957364 Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Observed issue using cmake:
This will help to keep iotjs in debian repo.
Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: https://github.com/jerryscript-project/iotjs/pulls?q=author%3Arzr
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net