Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple VCard #101

Closed
wants to merge 6 commits into from
Closed

Multiple VCard #101

wants to merge 6 commits into from

Conversation

rukandax
Copy link

You can generate multiple vcard by adding new method between each vcard.

What changes :

  • Add new method
  • getProperties method for getting properties from all contacts
  • getProperty method for getting properties from each contact, you can also getting properties from specific index using parameter

@Stadly Stadly mentioned this pull request Nov 2, 2017
@jeroendesloovere
Copy link
Owner

Hi @rukandax,
I really appreciate you have taken the time to create a PR for our VCard library.

Could you rename the method new to createNewVCard(), because new causes problems at it is a reserved method name.

@jeroendesloovere
Copy link
Owner

Would be nice if you can fix the PR asap, so I can release a new version 1.6.0 with this in it.
Thanks in advance.

Note: I'm creating a new VCard step by step that has multiple VCards build right in.
You can check the Work In Progress in the new-version branch

@rukandax rukandax closed this Feb 14, 2018
@NMathar
Copy link

NMathar commented Feb 23, 2018

Hi, need this pr is there another solution or should i use rukandax repo?

@jeroendesloovere
Copy link
Owner

Currently there is no released solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants