Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for ignoring reverse complements when checking neighbours #43

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

hmusta
Copy link
Contributor

@hmusta hmusta commented Feb 19, 2024

Since the k-mer lookup methods allow for ignoring reverse complements when checking the dictionary, I adapted the neighbourhood search methods to also allow for this.

I'm not sure if the current way of implementing neighbourhood searches is intended behaviour or a bug since the paper mentions that you consider both orientations of a k-mer to be equivalent.

Please let me know if you have any comments or if you'd like me to adapt some unit tests to check this extra functionality.

@jermp
Copy link
Owner

jermp commented Feb 19, 2024

Hi Harun and thanks for this! The bool was indeed necessary.

I'm not sure if the current way of implementing neighbourhood searches is intended behaviour or a bug since the paper mentions that you consider both orientations of a k-mer to be equivalent.

The correct implementation is the one you provided, with the bool being true.
Note however that there is no inconsistency with the paper nor its results, since I only benchmarked lookup not navigational queries.

@jermp jermp closed this Feb 19, 2024
@jermp jermp reopened this Feb 19, 2024
@jermp jermp merged commit 5a13d6a into jermp:master Feb 19, 2024
3 checks passed
@hmusta hmusta deleted the hmusta/traversal_fix branch February 19, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants