Fixed remaining unit test issues.

jepusto · Aug 28, 2020 · 2e49c35 · 2e49c35
1 parent 76d4102
commit 2e49c35
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/cran-comments.md b/cran-comments.md
@@ -2,7 +2,7 @@
 
 This is a new submission after the previous version of the package was archived on CRAN. My apologies for the delay in correcting the remaining errors identified. This happened because I was in the middle of a cross-country move, and it has taken me a while to get my family settled in our new home.
 
-This submission adds new functionality for Wald tests, along with expanded documentation and a vignette. This submission also fixes unit test errors that occur with MKL and noLD builds. I believe it also fixed the remaining MKL identified when I last tried to resubmit. However, I do not have access to a machine where I can exactly replicate the MKL check, and so I cannot be entirely certain.
+This submission adds new functionality for Wald tests, along with expanded documentation and a vignette. This submission also fixes unit test errors that occur with MKL and noLD builds. I believe I have also fixed the remaining MKL issue identified when I last tried to resubmit. However, I do not have access to a machine where I can exactly replicate the MKL check, and so I cannot be entirely certain.
 
 Please note that the DESCRIPTION file includes a citation to Bell and McCaffrey (2002), but unfortunately that article does not have a DOI; I have included a URL instead.
 

diff --git a/tests/testthat/test_glm_logit.R b/tests/testthat/test_glm_logit.R
@@ -186,8 +186,8 @@ test_that("clubSandwich works with aliased predictors", {
   CR_drop <- lapply(CR_types[-4], function(x) vcovCR(npk_drop, cluster = npk$block, type = x))
   expect_equal(CR_alias, CR_drop)
 
-  test_drop <- lapply(CR_types[-4], function(x) coef_test(npk_alias, vcov = x, cluster = npk$block, test = c("z","naive-t","Satterthwaite"), p_values = FALSE)[-13,])
-  test_complete <- lapply(CR_types[-4], function(x) coef_test(npk_drop, vcov = x, cluster = npk$block, test = c("z","naive-t","Satterthwaite"), p_values = FALSE))
+  test_drop <- lapply(CR_types[-4], function(x) coef_test(npk_alias, vcov = x, cluster = npk$block, test = c("z","naive-t","Satterthwaite"), coefs = 7:12, p_values = FALSE))
+  test_complete <- lapply(CR_types[-4], function(x) coef_test(npk_drop, vcov = x, cluster = npk$block, test = c("z","naive-t","Satterthwaite"), coefs = 7:12, p_values = FALSE))
   expect_equal(test_drop, test_complete)
 })
 

diff --git a/tests/testthat/test_lm.R b/tests/testthat/test_lm.R
@@ -216,8 +216,8 @@ test_that("clubSandwich works with aliased predictors", {
   CR_drop <- lapply(CR_types[-4], function(x) vcovCR(npk_drop, cluster = npk$block, type = x))
   expect_equal(CR_alias, CR_drop)
 
-  test_drop <- lapply(CR_types[-4], function(x) coef_test(npk_alias, vcov = x, cluster = npk$block, test = c("z","naive-t","Satterthwaite"), p_values = FALSE))
-  test_complete <- lapply(CR_types[-4], function(x) coef_test(npk_drop, vcov = x, cluster = npk$block, test = c("z","naive-t","Satterthwaite"), p_values = FALSE))
+  test_drop <- lapply(CR_types[-4], function(x) coef_test(npk_alias, vcov = x, cluster = npk$block, test = c("z","naive-t","Satterthwaite"), coefs = 7:12, p_values = FALSE))
+  test_complete <- lapply(CR_types[-4], function(x) coef_test(npk_drop, vcov = x, cluster = npk$block, test = c("z","naive-t","Satterthwaite"), coefs = 7:12, p_values = FALSE))
   expect_equal(test_drop, test_complete)
 })