fix race on signals counter construction (ydb-platform#2124)

jepett0 · Feb 21, 2024 · d7ed778 · d7ed778
1 parent 11c1356
commit d7ed778
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/ydb/core/tx/columnshard/blobs_action/counters/storage.cpp b/ydb/core/tx/columnshard/blobs_action/counters/storage.cpp
@@ -9,11 +9,7 @@ TStorageCounters::TStorageCounters(const TString& storageId)
 }
 
 std::shared_ptr<NKikimr::NOlap::NBlobOperations::TConsumerCounters> TStorageCounters::GetConsumerCounter(const TString& consumerId) {
-    auto it = ConsumerCounters.find(consumerId);
-    if (it == ConsumerCounters.end()) {
-        it = ConsumerCounters.emplace(consumerId, std::make_shared<TConsumerCounters>(consumerId, *this)).first;
-    }
-    return it->second;
+    return std::make_shared<TConsumerCounters>(consumerId, *this);
 }
 
 TConsumerCounters::TConsumerCounters(const TString& consumerId, const TStorageCounters& parent)

diff --git a/ydb/core/tx/columnshard/blobs_action/counters/storage.h b/ydb/core/tx/columnshard/blobs_action/counters/storage.h
@@ -25,7 +25,6 @@ class TConsumerCounters: public NColumnShard::TCommonCountersOwner {
 class TStorageCounters: public NColumnShard::TCommonCountersOwner {
 private:
     using TBase = NColumnShard::TCommonCountersOwner;
-    THashMap<TString, std::shared_ptr<TConsumerCounters>> ConsumerCounters;
 public:
     TStorageCounters(const TString& storageId);