Merge branch 'ydb-platform:stable-24-1' into stable-24-1

library/cpp/containers/disjoint_interval_tree/disjoint_interval_tree.h

@@ -132,7 +132,7 @@ class TDisjointIntervalTree {
         }
 
         TIterator completelyRemoveEnd = completelyRemoveBegin != Tree.end() ? Tree.lower_bound(end) : Tree.end();
-        if (completelyRemoveEnd != Tree.end() && completelyRemoveEnd != Tree.begin() && completelyRemoveEnd->first != end) {
+        if (completelyRemoveEnd != Tree.begin() && (completelyRemoveEnd == Tree.end() || completelyRemoveEnd->first != end)) {
             TIterator containingEnd = completelyRemoveEnd;
             --containingEnd;
             if (containingEnd->second > end) {

library/cpp/containers/disjoint_interval_tree/ut/disjoint_interval_tree_ut.cpp

@@ -232,6 +232,18 @@ Y_UNIT_TEST_SUITE(DisjointIntervalTreeTest) {
             UNIT_ASSERT_VALUES_EQUAL(tree.GetNumIntervals(), 2);
             UNIT_ASSERT_VALUES_EQUAL(tree.GetNumElements(), 8);
         }
+
+        // 12. The only one interval
+        {
+            TDisjointIntervalTree<ui64> tree;
+            tree.InsertInterval(1, 10);
+            UNIT_ASSERT_VALUES_EQUAL(tree.GetNumIntervals(), 1);
+            UNIT_ASSERT_VALUES_EQUAL(tree.GetNumElements(), 9);
+            UNIT_ASSERT_VALUES_EQUAL(tree.EraseInterval(0, 6), 5);
+            UNIT_ASSERT_VALUES_EQUAL(tree.GetNumIntervals(), 1);
+            UNIT_ASSERT_VALUES_EQUAL(tree.GetNumElements(), 4);
+            UNIT_ASSERT(tree.Intersects(5, 10));
+        }
     }
 
     Y_UNIT_TEST(IntersectsTest) {

ydb/core/kqp/provider/yql_kikimr_type_ann.cpp

@@ -429,7 +429,7 @@ class TKiSinkTypeAnnotationTransformer : public TKiSinkVisitorTransformer
                 continue;
             }
 
-            if (op == TYdbOperation::UpdateOn) {
+            if (op == TYdbOperation::UpdateOn || op == TYdbOperation::DeleteOn) {
                 continue;
             }
 

ydb/core/kqp/ut/scheme/kqp_constraints_ut.cpp

@@ -287,6 +287,99 @@ Y_UNIT_TEST_SUITE(KqpConstraints) {
         TestSerialType("serial8");
     }
 
+    Y_UNIT_TEST(DefaultsAndDeleteAndUpdate) {
+        NKikimrConfig::TAppConfig appConfig;
+        appConfig.MutableTableServiceConfig()->SetEnableSequences(false);
+        appConfig.MutableTableServiceConfig()->SetEnableColumnsWithDefault(true);
+        auto serverSettings = TKikimrSettings().SetAppConfig(appConfig);
+        TKikimrRunner kikimr(serverSettings);
+        auto db = kikimr.GetTableClient();
+        auto session = db.CreateSession().GetValueSync().GetSession();
+
+        {
+            auto query = R"(
+                --!syntax_v1
+                CREATE TABLE `/Root/DefaultsAndDeleteAndUpdate` (
+                    Key Int32,
+                    Value String DEFAULT "somestring",
+                    PRIMARY KEY (Key)
+                );
+            )";
+
+            auto result = session.ExecuteSchemeQuery(query).GetValueSync();
+            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS,
+                                       result.GetIssues().ToString());
+        }
+
+        {
+            TString query = R"(
+                UPSERT INTO `/Root/DefaultsAndDeleteAndUpdate` (Key) VALUES (1), (2), (3), (4);
+            )";
+
+            NYdb::NTable::TExecDataQuerySettings execSettings;
+            execSettings.KeepInQueryCache(true);
+            execSettings.CollectQueryStats(ECollectQueryStatsMode::Basic);
+
+            auto result =
+                session
+                    .ExecuteDataQuery(query, TTxControl::BeginTx().CommitTx(),
+                                      execSettings)
+                    .ExtractValueSync();
+
+            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS,
+                                       result.GetIssues().ToString());
+        }
+
+        {
+            TString query = R"(
+                SELECT * FROM `/Root/DefaultsAndDeleteAndUpdate`;
+            )";
+
+            NYdb::NTable::TExecDataQuerySettings execSettings;
+            execSettings.KeepInQueryCache(true);
+            execSettings.CollectQueryStats(ECollectQueryStatsMode::Basic);
+
+            auto result =
+                session
+                    .ExecuteDataQuery(query, TTxControl::BeginTx().CommitTx(),
+                                      execSettings)
+                    .ExtractValueSync();
+
+            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS,
+                                       result.GetIssues().ToString());
+            CompareYson(R"(
+                    [
+                        [[1];["somestring"]];
+                        [[2];["somestring"]];
+                        [[3];["somestring"]];
+                        [[4];["somestring"]]
+                    ]
+                )",
+                NYdb::FormatResultSetYson(result.GetResultSet(0)));
+        }
+
+        {
+            TString query = R"(
+                $object_pk = <|Key:1|>;
+                DELETE FROM `/Root/DefaultsAndDeleteAndUpdate` ON
+                SELECT * FROM AS_TABLE(AsList($object_pk));
+            )";
+
+            NYdb::NTable::TExecDataQuerySettings execSettings;
+            execSettings.KeepInQueryCache(true);
+            execSettings.CollectQueryStats(ECollectQueryStatsMode::Basic);
+
+            auto result =
+                session
+                    .ExecuteDataQuery(query, TTxControl::BeginTx().CommitTx(),
+                                      execSettings)
+                    .ExtractValueSync();
+
+            UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::SUCCESS,
+                                       result.GetIssues().ToString());
+        }
+    }
+
     Y_UNIT_TEST(AlterTableAddColumnWithDefaultValue) {
         NKikimrConfig::TAppConfig appConfig;
         appConfig.MutableTableServiceConfig()->SetEnableSequences(false);

ydb/core/protos/feature_flags.proto

@@ -104,7 +104,7 @@ message TFeatureFlags {
     optional bool EnableTopicDiskSubDomainQuota = 89 [default = true];
     optional bool EnableSeparationComputeActorsFromRead = 90 [default = false];
     optional bool EnablePQConfigTransactionsAtSchemeShard = 91 [default = false];
-    optional bool EnableScriptExecutionOperations = 92 [default = false];
+    optional bool EnableScriptExecutionOperations = 92 [default = true];
     optional bool EnableImplicitQueryParameterTypes = 93 [default = false];
     optional bool EnableForceImmediateEffectsExecution = 94 [default = false];
     optional bool EnableTopicSplitMerge = 95 [default = false];

ydb/core/protos/table_service_config.proto

@@ -234,7 +234,7 @@ message TTableServiceConfig {
     optional bool EnablePredicateExtractForDataQueries = 37 [default = true];
     optional bool EnableKqpImmediateEffects = 38 [default = true];
     optional bool EnableSequentialReads = 39 [default = true];
-    optional bool EnablePreparedDdl = 42 [default = false];
+    optional bool EnablePreparedDdl = 42 [default = true];
     optional bool EnableSequences = 43 [default = false];
     optional bool EnableAsyncComputationPatternCompilation = 48 [default = true];
     optional TCompileComputationPatternServiceConfig CompileComputationPatternServiceConfig = 47;

ydb/core/tx/scheme_board/replica.cpp

@@ -248,17 +248,6 @@ class TReplica: public TMonitorableActor<TReplica> {
             TrackMemory();
         }
 
-        explicit TDescription(
-                TReplica* owner,
-                const TPathId& pathId,
-                TOpaquePathDescription&& pathDescription)
-            : Owner(owner)
-            , PathId(pathId)
-            , PathDescription(std::move(pathDescription))
-        {
-            TrackMemory();
-        }
-
         explicit TDescription(
                 TReplica* owner,
                 const TString& path,
@@ -540,13 +529,13 @@ class TReplica: public TMonitorableActor<TReplica> {
     }
 
     // upsert description only by pathId
-    TDescription& UpsertDescription(const TPathId& pathId, TOpaquePathDescription&& pathDescription) {
+    TDescription& UpsertDescriptionByPathId(const TString& path, const TPathId& pathId, TOpaquePathDescription&& pathDescription) {
         SBR_LOG_I("Upsert description"
             << ": pathId# " << pathId
             << ", pathDescription# " << pathDescription.ToString()
         );
 
-        return Descriptions.Upsert(pathId, TDescription(this, pathId, std::move(pathDescription)));
+        return Descriptions.Upsert(pathId, TDescription(this, path, pathId, std::move(pathDescription)));
     }
 
     // upsert description by path AND pathId both
@@ -898,7 +887,7 @@ class TReplica: public TMonitorableActor<TReplica> {
             if (abandonedSchemeShards.contains(pathId.OwnerId)) { // TSS is ignored, present GSS reverted it
                 log("Replace GSS by TSS description is rejected, GSS implicitly knows that TSS has been reverted"
                     ", but still inject description only by pathId for safe");
-                UpsertDescription(pathId, std::move(pathDescription));
+                UpsertDescriptionByPathId(path, pathId, std::move(pathDescription));
                 return AckUpdate(ev);
             }
 
@@ -923,7 +912,7 @@ class TReplica: public TMonitorableActor<TReplica> {
             }
 
             log("Inject description only by pathId, it is update from GSS");
-            UpsertDescription(pathId, std::move(pathDescription));
+            UpsertDescriptionByPathId(path, pathId, std::move(pathDescription));
             return AckUpdate(ev);
         }