fixed, ignored shellcheck error, warning, and update github actions c…

…heckout version to the v4
jeonghanlee · Aug 20, 2024 · 7eba06b · 7eba06b
1 parent 8f221e8
commit 7eba06b
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: setup python
         uses: actions/setup-python@v2
         with:
@@ -54,7 +54,7 @@ jobs:
     container: debian:bullseye
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install required packages
         run: |
           apt update -y
@@ -81,7 +81,7 @@ jobs:
     container: rockylinux:8
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install required packages
         run: |
           dnf update -y

diff --git a/.github/workflows/debian12.yml b/.github/workflows/debian12.yml
@@ -20,7 +20,7 @@ jobs:
     container: debian:bookworm-slim
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install required packages
         run: |
           apt update -y

diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -13,7 +13,7 @@ jobs:
 
     steps:
       - name: Checkout Code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Lint Code Base
         uses: docker://github/super-linter:v4.8.1
         env:

diff --git a/.github/workflows/rocky9.yml b/.github/workflows/rocky9.yml
@@ -22,7 +22,7 @@ jobs:
     container: rockylinux/rockylinux:9
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install required packages
         run: |
           dnf install -y git make sudo bash wget unzip

diff --git a/.github/workflows/ubuntu22.yml b/.github/workflows/ubuntu22.yml
@@ -20,7 +20,7 @@ jobs:
     container: ubuntu:22.04
     steps:
       - name: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       - name: Install required packages
         run: |
           apt update -y

diff --git a/scripts/install_apps.bash b/scripts/install_apps.bash
@@ -16,7 +16,11 @@ function popd  { builtin popd  > /dev/null || exit; }
 function rocky_dist
 {
     local VERSION_ID
+    # shellcheck disable=SC2002
+    # shellcheck disable=SC2046
+    # shellcheck disable=SC2022
     eval $(cat /etc/os-release | grep -E "^(VERSION_ID)=")
+    # shellcheck disable=SC2086
     echo ${VERSION_ID}
 }
 
@@ -63,7 +67,7 @@ if [[ "${OS_NAME}" == "rocky" ]]; then
         autoreconf -i -v -f || exit
     else
         printf "\n";
-        printf "Doesn't support %s\n" "$dist";
+        printf "Doesn't support %s\n" "$rocky_version";
         printf "\n";
     fi