[JENKINS-46934] Avoid blocking forever due to log rotation #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
· Call logRotate asynchronously. · Impose a timeout on Owner.get. · While waiting for Owner.get, record the build in the thread name.
abayer
approved these changes
Sep 18, 2017
|
There is no timeout on log rotation here. Perhaps you misread the patch. |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
@jglick Durr. Mornings, man. |
|
At any rate I suppose this is @reviewbybees done unless you change your mind. |
|
Yup, was waiting to see if anyone else had any input. But they don't, so merging! |
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-46934
logRotateasynchronously.Owner.get.Owner.get, record the build in the thread name.@reviewbybees