Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use https for scm url instead of ssh #56

Merged
merged 1 commit into from
Oct 7, 2022
Merged

use https for scm url instead of ssh #56

merged 1 commit into from
Oct 7, 2022

Conversation

i-dipanshu
Copy link
Contributor

changed the general purpose scm url protocol to HTTPS

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

PR Motive

  • We don't need to use SSH protocol for read-only
  • the general purpose key should be HTTPS as we don't need any kind of private key to register to GitHub.

MarkEWaite
MarkEWaite approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 338776d into jenkinsci:master Oct 7, 2022
@i-dipanshu i-dipanshu deleted the update-scm-url branch October 8, 2022 14:11
@MarkEWaite MarkEWaite added the chore Reduces future maintenance label Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Reduces future maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-dipanshu @MarkEWaite