Use code for procxy host as well

jenkinsci · Aug 12, 2024 · c64b812 · c64b812
1 parent 6941ae3
commit c64b812
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/src/main/java/com/cloudbees/jenkins/support/impl/UpdateCenter.java b/src/main/java/com/cloudbees/jenkins/support/impl/UpdateCenter.java
@@ -73,7 +73,7 @@ private void addProxyInformation(PrintWriter out, ContentFilter filter) {
         out.println("=== Proxy ===");
         ProxyConfiguration proxy = Jenkins.get().getProxy();
         if (proxy != null) {
-            out.println(" - Host: " + ContentFilter.filter(filter, proxy.getName()));
+            out.println(" - Host: `" + Markdown.escapeBacktick(ContentFilter.filter(filter, proxy.getName())) + "`");
             out.println(" - Port: " + proxy.getPort());
             out.println(" - No Proxy Hosts: ");
             String noProxyHostsString = proxy.getNoProxyHost();

diff --git a/src/test/java/com/cloudbees/jenkins/support/impl/UpdateCenterTest.java b/src/test/java/com/cloudbees/jenkins/support/impl/UpdateCenterTest.java
@@ -26,19 +26,17 @@ public class UpdateCenterTest {
     public void testUpdateCenterProxyContent() {
 
         List<String> noProxyHosts = Arrays.asList(".server.com", "*.example.com");
-        j.jenkins
-                .get()
-                .setProxy(new ProxyConfiguration(
-                        "proxy.server.com",
-                        1234,
-                        "proxyUser",
-                        "proxyPass",
-                        String.join("\n", noProxyHosts),
-                        "http://localhost:8080"));
+        j.jenkins.setProxy(new ProxyConfiguration(
+                "proxy.server.com",
+                1234,
+                "proxyUser",
+                "proxyPass",
+                String.join("\n", noProxyHosts),
+                "http://localhost:8080"));
 
         String ucMdToString = SupportTestUtils.invokeComponentToString(
                 Objects.requireNonNull(ExtensionList.lookup(Component.class).get(UpdateCenter.class)));
-        assertThat(ucMdToString, containsString(" - Host: proxy.server.com"));
+        assertThat(ucMdToString, containsString(" - Host: `proxy.server.com`"));
         assertThat(ucMdToString, containsString(" - Port: 1234"));
         assertThat(ucMdToString, not(containsString("proxyUser")));
         assertThat(ucMdToString, not(containsString("proxyPass")));