Enable InjectedTest & fix found issues #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enable maven-enforcer-plugin to show plugin incompatibilities & fix them
- without these changes the plugin would fail to start in InjectedTest
- "git client" plugin v2.0.0 requires "structs" plugin v1.3 or later
(it was a transitive dependency via "display-url-api" plugin v1.1.1)
- "git" plugin v3.0.0 requires "credentials" plugin v2.1.4 or later
- all .jelly files should escape content per default
- this was reported via InjectedTest
- also see https://wiki.jenkins.io/display/JENKINS/Jelly+and+XSS+prevention
- explicit Hamcrest dependency declaration
- Hamcrest is used in the tests and therefore should be declared explicitly
- use the highest version to resolve version conflicts due to transisitivy
scaytrase
approved these changes
Jan 5, 2020
|
Thanks @darxriggs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(it was a transitive dependency via "display-url-api" plugin v1.1.1)