Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml: Use Apache HttpComponents Client 4.x API Plugin #239

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

proski
Copy link
Contributor

@proski proski commented Jul 27, 2019

This removes httpclient-4.5.8.jar and httpcore-4.4.11.jar from the plugin
package, cutting its size by over a megabyte.

Users can update the Apache HttpComponents plugin on their own without
waiting for other plugins to update their dependencies.

Apache HttpComponents plugin is likely to be installed already because
it's used by the git plugin.

This resolves #205. The only remaining bundled jar is sshd-core-0.14.0.jar

This removes httpclient-4.5.8.jar and httpcore-4.4.11.jar from the plugin
package, cutting its size by over a megabyte.

Users can update the Apache HttpComponents plugin on their own without
waiting for other plugins to update their dependencies.

Apache HttpComponents plugin is likely to be installed already because
it's used by the git plugin.
@scaytrase scaytrase merged commit 507f011 into jenkinsci:release/1.x Jul 27, 2019
@scaytrase
Copy link
Member

sounds great, thank you @proski !

@proski proski deleted the httpclient-plugin branch July 27, 2019 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to apache-httpcomponents-client-4-api-plugin instead of raw httpclient
2 participants