Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml: Make guava a test requirement #237

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

proski
Copy link
Contributor

@proski proski commented Jul 25, 2019

It is not needed for running the plugin and should not be packaged into
stashNotifier.hpi.

Guava was the largest contributor to the plugin size.

The plugin has been tested on Jenkins to make sure it works and posts notifications to Stash.

It is not needed for running the plugin and should not be packaged into
stashNotifier.hpi.
@scaytrase
Copy link
Member

Sounds great improvement

@scaytrase scaytrase merged commit 7a84093 into jenkinsci:release/1.x Jul 26, 2019
@scaytrase
Copy link
Member

Thank you, @proski !

@proski proski deleted the packaging branch July 27, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants