Remove option to set project key globally (was broken) #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project key feature was introduced in commit 04a09cc. The implementation had two flaws: 1) It contained projectKey in the Descriptor but did not provide this field in the UI (global.jelly). 2) The getBuildKey() method only used the global project key in one place. When expanding macros, only the job specific key was used.
scaytrase
approved these changes
Apr 2, 2019
|
thank you, @darxriggs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project key feature was introduced in commit 04a09cc.
The implementation had two flaws:
projectKeyin the Descriptor but did not provide this field in the UI (global.jelly).getBuildKey()method only used the global project key in one place. When expanding macros, only the job specific key was used.