Skip timing dependent test on Windows CI agents #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostic output inserted into the test shows that ci.jenkins.io Linux agents expire test events from the queue after roughly 3 seconds when the expire time is set to 3 seconds. Those same diagnostic statements show that the test events do not expire on the ci.jenkins.io Windows agents in the first 10 seconds even when the expire time is set to 3 seconds. I assume that is somehow due to differences in the file systems on ci.jenkins.io Windows agents compared to ci.jenkins.io Linux agents. Extend the wait time for ci.jenkins.io Windows tests to expire all the test events. Same problem is not visible on my Windows desktop computer. Only extend the time for Windows tests on CI.
|
@michaelneale, @vivek, @kzantow, @scherler, @davidbees, @richbg, @Carroll, @dnusbaum, @jtaboada, @kshultz, @bitwiseman, or @olamy I would appreciate very much if this were merged so that the ci.jenkins.io job on the master branch is passing again. We shouldn't block other pull requests due to failing tests on the master branch. |
olamy
reviewed
Feb 16, 2025
| // The Windows machines on ci.jenkins.io need extra time. Assumed due | ||
| // to a slower file system or slower storage. | ||
| if (Functions.isWindows() && System.getenv("CI") != null) { | ||
| waitTimer.waitUntil(13500); // 13.5 sec = 4.5 + 9 seconds cushion |
There was a problem hiding this comment.
Why not simply skip this test when running on Windows and CI?
By experience, this sort of number approximation tends to turn to result in flaky tests.
There was a problem hiding this comment.
Sure. Happy to do that as well.
There was a problem hiding this comment.
Pushed as 6453ddf
olamy
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip timing dependent test on Windows CI agents
Diagnostic output inserted into the test shows that ci.jenkins.io Linux agents expire test events from the queue after roughly 3 seconds when the expire time is set to 3 seconds. Those same diagnostic statements show that the test events do not expire on the ci.jenkins.io Windows agents in the first 10 seconds even when the expire time is set to 3 seconds.
I assume that is somehow due to differences in the file systems on ci.jenkins.io Windows agents compared to ci.jenkins.io Linux agents.
Extend the wait time for ci.jenkins.io Windows tests to expire all the test events.
Same problem is not visible on my Windows desktop computer. Only extend the time for Windows tests on CI.
Submitter checklist
Reviewer checklist