Refresh plugin for October 2023, including core version bump to 2.387.3 #196
Conversation
| <extensions xmlns="http://maven.apache.org/EXTENSIONS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/EXTENSIONS/1.0.0 http://maven.apache.org/xsd/core-extensions-1.0.0.xsd"> | ||
| <extension> | ||
| <groupId>io.jenkins.tools.incrementals</groupId> | ||
| <artifactId>git-changelist-maven-extension</artifactId> | ||
| <version>1.7</version> | ||
| </extension> | ||
| </extensions> |
| -Pconsume-incrementals | ||
| -Pmight-produce-incrementals |
| [platform: 'linux', jdk: 21], | ||
| [platform: 'windows', jdk: 17], |
| "mvnbuild": "gulp bundle", | ||
| "mvntest": "gulp test" |
There was a problem hiding this comment.
Newer version of NPM complains about this duplicate key. The second version was the one actually being used anyway.
| @@ -4,31 +4,34 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>4.66</version> | |||
| <version>4.74</version> | |||
There was a problem hiding this comment.
Latest at the time of this writing.
| <connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | ||
| <developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection> | ||
| <url>https://github.com/${gitHubRepo}</url> | ||
| <tag>${scmTag}</tag> |
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.13.2</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Managed in the plugin parent POM.
| </dependencies> | ||
| </dependencyManagement> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>pubsub-light</artifactId> | ||
| <version>1.17</version> |
There was a problem hiding this comment.
Managed in the plugin BOM.
| @@ -86,7 +81,7 @@ | |||
| <dependency> | |||
| <groupId>com.github.eirslett</groupId> | |||
| <artifactId>frontend-plugin-core</artifactId> | |||
| <version>1.12.1</version> | |||
| <version>${frontend-version}</version> | |||
There was a problem hiding this comment.
Managed in the plugin parent POM.
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>findbugs-maven-plugin</artifactId> | ||
| <version>3.0.5</version> | ||
| </plugin> |
|
@olamy , @car-roll , or @dwnusbaum could you review and merge this? We are announcing Java 21 support in Jenkins 2.426.1 on 15 Nov 2023 and would like most of the top 250 plugins to already be testing with Java 21. One of the benefits of this pull request is that it implements Java 21 and Java 17 support. |
|
@MarkEWaite the PR includes a core requirement bump. Not sure if it's really important for this plugin to require to have it mentioned in the PR title and not having the label |
|
ok let's say it's not important |
|
I like mentioning core requirement bumps in PR titles for my own convenience. It helps me identify transition points in the plugin release history. You're welcome to update the title of the pull request to mention that it now requires Jenkins 2.,387.3. I have been using |
See #194