Introduce a channel name to ID cache #965
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964
Testing done
Tested on a large workspace (~1900 channels) where this only worked for 1 file upload before it got rate limited before.
It now works as long as you don't clear the cache and then immediately try upload a file.
I added in some functionality to refresh when a channel isn't found so that new channels are picked up immediately, to de- risk it I made it not invalidate the old cache on errors.
I've tested it quite thoroughly, but its quite painful, really annoying of slack to implement it like this...
Submitter checklist