Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a channel name to ID cache #965

Merged
merged 2 commits into from
May 7, 2024

Conversation

timja
Copy link
Member

@timja timja commented May 7, 2024

Fixes #964

Testing done

Tested on a large workspace (~1900 channels) where this only worked for 1 file upload before it got rate limited before.
It now works as long as you don't clear the cache and then immediately try upload a file.

I added in some functionality to refresh when a channel isn't found so that new channels are picked up immediately, to de- risk it I made it not invalidate the old cache on errors.

I've tested it quite thoroughly, but its quite painful, really annoying of slack to implement it like this...

Submitter checklist

Preview Give feedback

@timja timja requested a review from a team as a code owner May 7, 2024 15:59
@timja timja added the bug label May 7, 2024
@timja timja enabled auto-merge (squash) May 7, 2024 18:40
@timja timja merged commit 62ffe7c into jenkinsci:master May 7, 2024
14 checks passed
@timja timja deleted the cache-conversations branch May 7, 2024 19:29
@sebaturen
Copy link

Hi! This update removes the possibility to upload files under the threads using threadId from the last message sent. Is this intentional, or am I missing the option to use threadId again?

@timja
Copy link
Member Author

timja commented Jun 3, 2024

Hi please create an issue with steps to reproduce.

I am able to upload files in threads using the instructions in the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limiting is occurring for the conversations.list API when uploading files
2 participants