Make slack response safer #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-foster
approved these changes
Dec 15, 2018
| @@ -41,6 +41,9 @@ | |||
| */ | |||
| public class SlackSendStep extends AbstractStepImpl { | |||
|
|
|||
| private static final String ERROR_PARSING_SLACK_RESPONSE = "Could not parse response from slack, potentially " | |||
There was a problem hiding this comment.
these strings conventionally go in https://github.com/jenkinsci/slack-plugin/blob/master/src/main/resources/jenkins/plugins/slack/Messages.properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles invalid configuration and any other edge cases by adding null checks and catching json parse exceptions
Errors are logged so that the user can fix their config
Fixes #438